Discussion:
[Django] #25174: System Check documentation lacking location
Django
2015-07-25 22:03:36 UTC
Permalink
#25174: System Check documentation lacking location
-------------------------------+--------------------
Reporter: jrabbit | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
https://docs.djangoproject.com/en/1.8/topics/checks/ doesn't say where
django looks for these checks... it looks like checks.py is the right
answer. but maybe also checks/

--
Ticket URL: <https://code.djangoproject.com/ticket/25174>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/050.cc96a3a682f92cbc0398068170bc0e6d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-25 22:35:07 UTC
Permalink
#25174: System Check documentation lacking location
-------------------------------+--------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by jrabbit):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Post by Django
https://docs.djangoproject.com/en/1.8/topics/checks/ doesn't say where
django looks for these checks... it looks like checks.py is the right
answer. but maybe also checks/
New description:

https://docs.djangoproject.com/en/1.8/topics/checks/ doesn't say where
django looks for these checks... it looks like checks.py is the right
answer.

edit: So It appears that you need to hook the checks into django yourself?
(e.g. via Appconfig) This seems like a high bar of entry but it needs to
be documented better

--

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.6f19f6e9b43dd46633b053cbc7429bcb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-25 23:34:41 UTC
Permalink
#25174: System Check documentation lacking location
-------------------------------+--------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by timgraham):

I think it's documented pretty well in
[https://docs.djangoproject.com/en/1.8/topics/checks/#registering-and-
labeling-checks Registering and labeling checks], but feel free to suggest
a patch if something is unclear.

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.9382ae0f01b5876e009793010d890fdf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-26 08:30:12 UTC
Permalink
#25174: System Check documentation lacking location
-------------------------------+--------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by bmispelon):

The "Registering and labeling checks" section has the right information
indeed but it's not that obvious that you should read it.

I think the problem is the reference documentation of `CheckMessage` that
sits between the code example that uses `@register` without telling you
where the code should live, and the paragraph that suggests you to put the
code in an `AppConfig.ready()` method.
Personally, it made me switch between the "read as text, from top to
bottom" mode (ie "topic-style" documentation) to the "hop around trying to
find the info I'm looking for" mode (ie "reference-style" documentation).

Could we maybe move the bulk of the reference documentation for
`CheckMessage` into the `/ref/` documentation section?

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.00f95973b4db7418a10539fdfa804f85%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-28 13:30:04 UTC
Permalink
#25174: Move some details of CheckMessage to the reference guide.
--------------------------------------+------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted
* type: Uncategorized => Cleanup/optimization


Comment:

[https://github.com/django/django/pull/5057 Proposal]

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.be0f2e1608fe6595fe5f10198cf71ca5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-31 12:44:23 UTC
Permalink
#25174: Move some details of CheckMessage to the reference guide.
--------------------------------------+------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"faa2a0f662ed6fe0b90d10e98cc8ee3795d9307c" faa2a0f]:
{{{
#!CommitTicketReference repository=""
revision="faa2a0f662ed6fe0b90d10e98cc8ee3795d9307c"
Fixed #25174 -- Moved some details of CheckMessage to the reference guide.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.9da1cca74acc8bda9dcdc6e417c7e47f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Django
2015-07-31 12:48:36 UTC
Permalink
#25174: Move some details of CheckMessage to the reference guide.
--------------------------------------+------------------------------------
Reporter: jrabbit | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"386a6dc3d76fe01df1929503b00755bfce987b32" 386a6dc3]:
{{{
#!CommitTicketReference repository=""
revision="386a6dc3d76fe01df1929503b00755bfce987b32"
[1.8.x] Fixed #25174 -- Moved some details of CheckMessage to the
reference guide.

Backport of faa2a0f662ed6fe0b90d10e98cc8ee3795d9307c from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25174#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups "Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+***@googlegroups.com.
To post to this group, send email to django-***@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/065.76fa7810bb952a24e03995b261731a2b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
Loading...